-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: test cases for Add deposit #403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix pipeline issue please
test failed
@mexes20 ANy updates? |
web_app/tests/test_positions.py
Outdated
"""Test cases for add_extra_deposit endpoint""" | ||
|
||
@pytest.mark.asyncio | ||
@patch('your_module.position_db_connector') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you can't even run it locally right and discovered that chatgpt doesn't know about your file structure?
just copy/paste chatgpt 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you can't even run it locally right and discovered that chatgpt doesn't know about your file structure? just copy/paste chatgpt 😂
Hahaha this is funny, I actually refactored the whole test there because there were a lot of redundant code and docstrings but decided against it to see what test will fail in the CI first. I'll fix those now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix please imports in patching
On it |
@mexes20 any updates? |
Yes |
@mexes20 Any updates? |
Added the complete test already. |
github pipeline is failed @mexes20 |
@mexes20 I will give you time to the evening (6-7 hours), If you can't manage with this easy task I think I will merge as it is and will fix rest failed test cases. |
Hey @djeck1432 I have already fixed for the rest, but this seems to be some sort of bottle neck for me, I'll appreciate some assistance. |
@mexes20 I don't really know what have you done, because all your tests failed, which type of assistance do you want to get don't understand as well |
@mexes20 I will merge what you have and fix test cases |
@mexes20 fixed all test cases within 5 mins, what did you do for 24 hours? I don't know |
No description provided.