Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test cases for Add deposit #403

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Conversation

mexes20
Copy link
Contributor

@mexes20 mexes20 commented Dec 18, 2024

No description provided.

@djeck1432 djeck1432 self-requested a review December 18, 2024 10:48
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pipeline issue please
test failed

@djeck1432 djeck1432 linked an issue Dec 18, 2024 that may be closed by this pull request
@djeck1432
Copy link
Owner

@mexes20 ANy updates?

"""Test cases for add_extra_deposit endpoint"""

@pytest.mark.asyncio
@patch('your_module.position_db_connector')
Copy link
Owner

@djeck1432 djeck1432 Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you can't even run it locally right and discovered that chatgpt doesn't know about your file structure?
just copy/paste chatgpt 😂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you can't even run it locally right and discovered that chatgpt doesn't know about your file structure? just copy/paste chatgpt 😂

Hahaha this is funny, I actually refactored the whole test there because there were a lot of redundant code and docstrings but decided against it to see what test will fail in the CI first. I'll fix those now.

Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix please imports in patching

@mexes20
Copy link
Contributor Author

mexes20 commented Dec 18, 2024

Fix please imports in patching

On it

@djeck1432
Copy link
Owner

@mexes20 any updates?

@mexes20
Copy link
Contributor Author

mexes20 commented Dec 19, 2024

@mexes20 any updates?

Yes

@djeck1432
Copy link
Owner

@mexes20 Any updates?

@mexes20
Copy link
Contributor Author

mexes20 commented Dec 19, 2024

@mexes20 Any updates?

Added the complete test already.

@djeck1432
Copy link
Owner

djeck1432 commented Dec 19, 2024

Screenshot 2024-12-19 at 10 15 30 github pipeline is failed @mexes20

@djeck1432
Copy link
Owner

@mexes20 I will give you time to the evening (6-7 hours), If you can't manage with this easy task I think I will merge as it is and will fix rest failed test cases.

@mexes20
Copy link
Contributor Author

mexes20 commented Dec 19, 2024

Hey @djeck1432 I have already fixed for the rest, but this seems to be some sort of bottle neck for me, I'll appreciate some assistance.

@djeck1432
Copy link
Owner

Screenshot 2024-12-19 at 18 18 22 @mexes20 I don't really know what have you done, because all your tests failed, which type of assistance do you want to get don't understand as well

@djeck1432
Copy link
Owner

@mexes20 I will merge what you have and fix test cases
thank you

@djeck1432 djeck1432 merged commit 30f8597 into djeck1432:main Dec 19, 2024
3 of 4 checks passed
@djeck1432
Copy link
Owner

@mexes20 fixed all test cases within 5 mins, what did you do for 24 hours? I don't know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Add test cases for new endpoints
2 participants